Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 [FEAT] Support h / l to switch between panes #96

Closed
sathishmanohar opened this issue Mar 12, 2023 · 7 comments
Closed

💡 [FEAT] Support h / l to switch between panes #96

sathishmanohar opened this issue Mar 12, 2023 · 7 comments
Assignees
Labels
completed Issues that are fixed and will be out in the next release enhancement New feature or request

Comments

@sathishmanohar
Copy link
Contributor

Currently only tab key seems to be supported. Even shift+tab didn't work when I tried to go back to the previous pane.

Since dooit is going for vim like keybindings, I think using h and l keys to switch focus to previous and next panes would be a lot more intuitive.

@sathishmanohar sathishmanohar added the enhancement New feature or request label Mar 12, 2023
@kraanzu
Copy link
Owner

kraanzu commented Mar 12, 2023

Ah yes, you can change that in the config file

It should be present at ~/.config/dooit/config.py

Since there are only two tabs, I only kept one keybind to toggle between the panes
You can configure the keys in the config file
here's an example

@sathishmanohar
Copy link
Contributor Author

Got it. Looks like there is currently support for one command to switch panes which is switch pane so the h / l approach can't be done in config files. Maybe when next pane and previous pane are implemented. This issue can be revisited.

@kraanzu
Copy link
Owner

kraanzu commented Mar 12, 2023

Alright, I'll add those!

@sathishmanohar
Copy link
Contributor Author

Awesome!

h or <shift+tab> for previous pane
l or <tab> for next pane

would be a great default biding. These bindings can scale if there is third pane implemented in the future for notes or other things.

@Justinzobel
Copy link

I'd love to see the left and right arrow keys work as well. I can't get used to checking which pane is highlighted before using my arrow keys to navigate up/down.

@sathishmanohar
Copy link
Contributor Author

@Justinzobel I've sometimes felt the active pane border color is sometimes confusing because it is a muted color. If that is what you mean. I think it should be a separate issue.

@kyeboard kyeboard self-assigned this Aug 13, 2023
@kyeboard kyeboard added the completed Issues that are fixed and will be out in the next release label Aug 13, 2023
@kraanzu
Copy link
Owner

kraanzu commented Sep 1, 2023

Fixed in new release

@kraanzu kraanzu closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed Issues that are fixed and will be out in the next release enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants