Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Deleting a task with child nodes crashes #169

Closed
trag1c opened this issue Jan 24, 2024 · 5 comments
Closed

[BUG] Deleting a task with child nodes crashes #169

trag1c opened this issue Jan 24, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@trag1c
Copy link

trag1c commented Jan 24, 2024

Describe the bug 🐛
When creating a task with child nodes, trying to remove the parent task results in a crash. The task does get deleted successfully though.

To Reproduce 🐣
Steps to reproduce the behavior:

  1. Create a task foo
  2. Add a child task bar to it
  3. Try removing task foo (xx)
  4. See error

Desktop (please complete the following information): 🤖

  • OS: macOS
  • Version: 14.2.1

Additional context 📝

╭─────────────────────────────────── Traceback (most recent call last) ────────────────────────────────────╮
│ /Users/trag1c/.local/pipx/venvs/dooit/lib/python3.12/site-packages/textual/app.py:3271 in _on_notify     │
│                                                                                                          │
│   3268 │                                                                                                 │
│   3269 │   def _on_notify(self, event: Notify) -> None:                                                  │
│   3270 │   │   """Handle notification message."""                                                        │
│ ❱ 3271 │   │   self._notifications.add(event.notification)                                               │
│   3272 │   │   self._refresh_notifications()                                                             │
│   3273 │                                                                                                 │
│   3274 │   def _unnotify(self, notification: Notification, refresh: bool = True) -> None:                │
│                                                                                                          │
│ ╭─────────────────────── locals ───────────────────────╮                                                 │
│ │ event = Notify()                                     │                                                 │
│ │  self = Dooit(title='Dooit', classes={'-dark-mode'}) │                                                 │
│ ╰──────────────────────────────────────────────────────╯                                                 │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────╯
AttributeError: 'Notify' object has no attribute 'notification'
@trag1c trag1c added the bug Something isn't working label Jan 24, 2024
@kraanzu
Copy link
Owner

kraanzu commented Jan 25, 2024

Hmm .. I thought this was fixed in dev but maybe not
Pushing a fix!

Thanks for opening an issue!

@kraanzu
Copy link
Owner

kraanzu commented Jan 25, 2024

Should be fixed in the latest release! Can you re-check?
Thanks

@kraanzu
Copy link
Owner

kraanzu commented Feb 2, 2024

I'm closing this for now. Feel free to reopen if the problem still persists
Thank you ❤️

@kraanzu kraanzu closed this as completed Feb 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

Did we solve your problem?
Glad we could help!

Consider sponsoring my work through github sponsors 😄
@kraanzu

@trag1c
Copy link
Author

trag1c commented Feb 2, 2024

Hey I forgot to check, sorry 😅 The problem is indeed fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants