Convert vector code from cgmath
to euclid
.
#402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gains:
no_std
compatibility.bytemuck
andarbitrary
implementations for vectors.GridMatrix
becauseeuclid::Transform3D
doesn't mind integers. (I haven't tried that yet.)Losses:
_unit
field making pattern matching awkward.Vector4
.map()
andzip()
methods, so we need an extension trait (but on average fewer traits needed).There are a number of loose ends from this migration, which have been marked with the keyword "
TODO(euclid migration)
".