Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression when rendering links with unusual content #64

Closed
Thomas-Haase opened this issue Feb 3, 2021 · 3 comments
Closed

Regression when rendering links with unusual content #64

Thomas-Haase opened this issue Feb 3, 2021 · 3 comments

Comments

@Thomas-Haase
Copy link

With my Markdown files I see a regression in 5.0. In the previous releases 4.4, 4.3 and 4.2 I got rendered results as expected. I have a link on page 1 to some header on page 2.
With 5.0 this link on page 1 is rendered e.g. as v71), and the appearance of the closing round bracket is the regression.
My Markdown on page 1 is:
[v71](Page2#Page2-Releasev71-22-Feb-2018(intern))
The link destination is a Markdown header on page 2, which is as follows:
#### Release v71 - 22-Feb-2018 (intern)

I admit, having this round brackets in the header links is probably not the best an most fail-safe idea, but it did work as expected in 4.4 and its predecessors.

@kovetskiy
Copy link
Owner

This is related to the regression in blackfriday. I've sent a patch to blackfriday's upstream.

For now, you can just escape the closing paren with a backslash.

russross/blackfriday#679

kovetskiy added a commit that referenced this issue Feb 4, 2021
@kovetskiy
Copy link
Owner

We'll go with my fork for now, doesn't look like russross has enough time for merging contributions right now.
The issue should be fixed in v5.2.

@Thomas-Haase
Copy link
Author

Yes, I can confirm, that it is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants