Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcachefs-tools isn't handling userspace mount options #342

Open
jpsollie opened this issue Oct 14, 2024 · 0 comments
Open

bcachefs-tools isn't handling userspace mount options #342

jpsollie opened this issue Oct 14, 2024 · 0 comments

Comments

@jpsollie
Copy link

When we specify in bcachefs kernel code that unknown options cause a mount failure (instead of gracefully ignoring them), all mounts which are performed by the bcachefs helper and have a userspace attribute set in /etc/fstab will fail.
I dug through the util-linux code and found this particular function:
https://github.com/util-linux/util-linux/blob/master/libmount/src/optmap.c#L214C28-L214C51
so, somehow, we should use it to validate whether the options specified are userspace options (and in case we don't deal with it in the userspace helper, we ignore them), or pass them to the kernel mount syscall.
I'm opening a ticket here, because it's clearly something that is a major issue when the git commit for failing on unknown mount options is pulled and userspace mount options have not yet been implemented.
Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant