Mock Redis connection for testing environment

[amedrz]

Hi guys, I just noticed that Redis isn't being stubbed when running the specs from my app.

Then I realized that folks from the sidekiq-unique-jobs gem ran into the same isssue:

mhenrixon/sidekiq-unique-jobs#18

Shall we do something similar here? just give me the call.

Thanks!

[kosmatov]

I think that is bad idea to run functional tests with stubbed environment. Just create unit tests if you need and run them separately.

[amedrz]

@kosmatov would you recommend to have Redis up while running specs instead? I'm not sure about that since Sidekiq itself has helpers to mock Redis calls in unit tests

https://github.com/mperham/sidekiq/wiki/Testing#wiki-testing-worker-queueing-fake

[kosmatov]

Oh, ok, I understand what you want. I'll see how fake! realized in Sidekiq and write required code. I don't like how it realized in sidekiq-unique-jobs because it's violates DI principle.

[amedrz]

Ok thanks. Currently I have to add this to the spec files of my workers that use sidekiq-benchmark

before { Sidekiq.stub(:redis).and_return(MockRedis.new) }

Workers using just sidekiq or sidekiq-unique-jobs don't need that.

[doomspork]

👍 I'm all for this feature!

[kosmatov]

https://github.com/kosmatov/sidekiq-benchmark#testing-sidekiq-workers

[amedrz]

👍