From f8483d6aab7ddd0d1e6d1d57b2ec2e29dae5a998 Mon Sep 17 00:00:00 2001 From: Kor Nielsen Date: Mon, 5 Feb 2024 12:45:41 -0800 Subject: [PATCH] test-matrix: Fix failure with artifact redirects. GitHub's API is now redirecting requests to download GHA artifacts to https://productionresultssa0.blob.core.windows.net/. This service rejects requests that contain an Authorization header, breaking our publish-website.yml workflow. octocrab should not be sending this header when redirected, and I have filed https://github.com/XAMPPRocky/octocrab/pull/562 to address the bug. Until that PR is merged, we can work around this issue by enabling octocrab's "follow-redirect" feature, which configures the tower middleware to handle the redirect instead of octocrab, which (correctly) doesn't include the authentication header in the redirected requests. --- ci-tools/test-matrix/Cargo.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ci-tools/test-matrix/Cargo.toml b/ci-tools/test-matrix/Cargo.toml index 33f8558374..24f9917ec6 100644 --- a/ci-tools/test-matrix/Cargo.toml +++ b/ci-tools/test-matrix/Cargo.toml @@ -10,9 +10,9 @@ edition = "2021" [dependencies] bytes = "1.5.0" nextest-metadata = "0.9" -octocrab = { version = "0.32.0", default-features = false, features = ["rustls"] } +octocrab = { version = "0.32.0", default-features = false, features = ["rustls", "follow-redirect"] } serde = "1.0.193" serde-xml-rs = "0.6.0" tinytemplate = { version = "1.1" } tokio = { version = "1.34.0", default-features = false, features = ["macros", "rt"] } -zip = { version = "0.6.6", default-features = false, features = ["deflate"] } \ No newline at end of file +zip = { version = "0.6.6", default-features = false, features = ["deflate"] }