Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code mirror keybindings interfere with some keyboard layouts #555

Closed
amir-zeldes opened this issue Apr 26, 2017 · 1 comment
Closed

Code mirror keybindings interfere with some keyboard layouts #555

amir-zeldes opened this issue Apr 26, 2017 · 1 comment
Assignees
Labels

Comments

@amir-zeldes
Copy link
Collaborator

By default, CodeMirror uses emacs-y keyboard bindings, which some languages use for input. For example, on the Mac Coptic keyboard layout, option+f inputs the letter phi (the same is true for option+d). This does not work in the AQL box due to keybindings from codemirror.

To reproduce:

  1. follow instructions to install Mac Coptic layout here: http://www.evertype.com/fonts/coptic/
  2. activate the layout in a word processor and type option+f - works fine
  3. do the same in AQL box - no character is printed

The following issue suggests a fix, which I can confirm works in another CodeMirror project I have:

codemirror/codemirror5#3254

Basically on initializing the CodeMirror textarea, the bindings should be deleted:

delete CodeMirror.keyMap.emacsy["Alt-F"]; 
delete CodeMirror.keyMap.emacsy["Alt-D"];
@thomaskrause
Copy link
Member

From what I see in the documentation these keybindings should be only active if the mode is explicitly set to "emacs" and if we have the emacs keybinding file included. Both should not be the case. I think the functionality of both is not really needed. I have to check on a mac why these key bindings are triggered (the solution would be to not support emacs keybindings at all)

@thomaskrause thomaskrause self-assigned this May 15, 2017
@thomaskrause thomaskrause added this to the 3.5.0 milestone Jun 19, 2017
@thomaskrause thomaskrause modified the milestones: 3.5.0, 3.5.0-preview4 Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants