Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved help messages of exporters into the exporter classes themselves. #408

Closed
wants to merge 3 commits into from

Conversation

larilampen
Copy link
Contributor

The help messages for the exporter classes are defined in the ExportPanel class. Adding a new exporter or just simply changing the order of the exporters will break the help messages if they are not also changed, which is easy to forget. I added a getHelpMessage method to the Exporter interface. Now adding or reordering importers does not require changes to ExportPanel anymore.

@thomaskrause thomaskrause added this to the 3.3.0 milestone May 22, 2015
@thomaskrause thomaskrause self-assigned this May 22, 2015
@thomaskrause
Copy link
Member

Hi, thanks for the pull request! Do you intend to include the OrfeoExporter in the commits as well and if yes would it be ok to position it at the end of the list (so it would not be the default any longer)?

For the next release we should also consider to make the exporters pluggable in the same way as the visualizers.

@larilampen
Copy link
Contributor Author

Hi Thomas,

At the moment I'm not planning to include OrfeoExporter. It's too specific to be included in the full ANNIS codebase. I have a few other changes ongoing that are similarly only applicable for our use in the Orfeo project, because we can make certain assumptions: speaker information is stored in a tier called 'speaker'; there is a metadata field 'url' with special meaning; the only trees we use are relatively local ones (syntactic dependency and constituent trees), etc. You can't assume those things in a general context since other ANNIS users will disagree.

I made the pull request because that change is so simple and generic, and it doesn't change any visible behaviours. If I make other generally useful changes, I'll also suggest them to you, but I expect most of my changes will stay in a separate fork of ANNIS that is not suitable to be merged into the general codebase.

@larilampen
Copy link
Contributor Author

Sorry, I just noticed I made a mess of the branches. I only intended for the first of the commits to be in the pull request. Let me close this and try again.

@larilampen larilampen closed this May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants