Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit marking in KWIC for segmentations precedence queries is incorrect #126

Closed
amir-zeldes opened this issue May 30, 2013 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@amir-zeldes
Copy link
Collaborator

The following query in apophthegmata.patrum.5 leads to hits which are correctly marked in the grid, but in KWIC only one of the two hit positions is colored (sometimes #1 in red, sometimes #2 in purple):

dipl=/.../ & dipl=/.../ & #1 .dipl #2

Switching to dipl segmentation solves the problem. The tokens corresponding to both positions should be colored correctly even if the segmentation is set to tokens in the base text menu.

If yet another segmentation is selected, then the element in that segmentation corresponding to the position of the hit should be considered the hit position. For example, if "word" segmentation is chosen, and the hits are "the" and the first letter of "h"[ouse], then the entire word "house" should be marked purple as #2 (since it is impossible to know/guarantee that only the substring 'h' is the intended hit on the word level).

If multiple hit elements are contained within the same segmentation unit that has been selected for display, then the entire segmentation unit gets the color of the lowest hit element. For example, if

"h" & "ouse" & #1. #2 

is searched for, and the word segmentation is selected for KWIC, then the whole word "house" should be red.

@ghost ghost assigned pixeldrama May 30, 2013
@pixeldrama
Copy link
Contributor

@amir-zeldes think you should check my solution, probably there are some corner cases left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants