-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Plugin] Unclear gradle-plugin attribute settings for Bintray #164
Comments
I think this might be a side effect of publishing all Kordamp plugins under the same package. |
Hm, and they shouldn't be published like that? I also published like that because I saw you do it 😃 Actually, on my first attempt to include tlinkowski-superpom package in JCenter, JFrog Support raised concerns about putting two logical packages under one. However, I referred them to kordamp-gradle-plugins, and they responded just with:
Anyway, I wonder how this |
It's a convenience to put all "modules" under a single package, as you can sync with Maven Central with the click of a button instead of many. In the past I configured a package per project (like this https://bintray.com/griffon/griffon) and the Bintray plugin did not allow automatic syncing with MC. It was a tedious task to sync every package manually. |
I see, thanks for the insight. However, even though Bintray plugin does support automatic MC sync now, it still "feels" somewhat better to have all the modules of a single project in a single place (being a Bintray package). This seems to correspond to how they share versions and other metadata. |
I believe the |
The following code adds a
gradle-plugin
attribute for Bintray:https://github.com/aalmiray/kordamp-gradle-plugins/blob/d2b636a55fff4c4aece45d634849c9a99764b877/plugins/plugin-gradle-plugin/src/main/groovy/org/kordamp/gradle/plugin/plugin/PluginPlugin.groovy#L114-L117
However, this is set per entire project, so I'm wondering if this works as intended.
For example, for the latest version of Kordamp (0.25.0 on Bintray), the value of this attribute is:
PS. I noticed this because I want to upload my Gradle plugin publications to Bintray without applying Kordamp's Plugin plugin (tlinkowski/tlinkowski-superpom#45), and I'm wondering whether I need this
gradle-plugin
attribute or not.The text was updated successfully, but these errors were encountered: