Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] Unclear gradle-plugin attribute settings for Bintray #164

Closed
tlinkowski opened this issue Aug 7, 2019 · 5 comments
Closed

[Plugin] Unclear gradle-plugin attribute settings for Bintray #164

tlinkowski opened this issue Aug 7, 2019 · 5 comments
Assignees
Milestone

Comments

@tlinkowski
Copy link
Contributor

The following code adds a gradle-plugin attribute for Bintray:
https://github.com/aalmiray/kordamp-gradle-plugins/blob/d2b636a55fff4c4aece45d634849c9a99764b877/plugins/plugin-gradle-plugin/src/main/groovy/org/kordamp/gradle/plugin/plugin/PluginPlugin.groovy#L114-L117

However, this is set per entire project, so I'm wondering if this works as intended.

For example, for the latest version of Kordamp (0.25.0 on Bintray), the value of this attribute is:

org.kordamp.gradle.build-scan:org.kordamp.gradle:buildscan-gradle-plugin

PS. I noticed this because I want to upload my Gradle plugin publications to Bintray without applying Kordamp's Plugin plugin (tlinkowski/tlinkowski-superpom#45), and I'm wondering whether I need this gradle-plugin attribute or not.

@tlinkowski tlinkowski changed the title Unclear gradle-plugin attribute settings for Bintray [Plugin] Unclear gradle-plugin attribute settings for Bintray Aug 7, 2019
@aalmiray
Copy link
Collaborator

aalmiray commented Aug 9, 2019

I think this might be a side effect of publishing all Kordamp plugins under the same package.

@tlinkowski
Copy link
Contributor Author

Hm, and they shouldn't be published like that? I also published like that because I saw you do it 😃

Actually, on my first attempt to include tlinkowski-superpom package in JCenter, JFrog Support raised concerns about putting two logical packages under one. However, I referred them to kordamp-gradle-plugins, and they responded just with:

Your request to include your package /tlinkowski/maven/tlinkowski-superpom in Bintray's JCenter has been approved.

Anyway, I wonder how this gradle-plugin attribute might be useful... I also have this attribute set to the first plugin now (pl.tlinkowski.gradle.my.settings:pl.tlinkowski.gradle.my:my-settings-gradle-plugin).

@aalmiray
Copy link
Collaborator

aalmiray commented Aug 9, 2019

It's a convenience to put all "modules" under a single package, as you can sync with Maven Central with the click of a button instead of many. In the past I configured a package per project (like this https://bintray.com/griffon/griffon) and the Bintray plugin did not allow automatic syncing with MC. It was a tedious task to sync every package manually.

@tlinkowski
Copy link
Contributor Author

I see, thanks for the insight.

However, even though Bintray plugin does support automatic MC sync now, it still "feels" somewhat better to have all the modules of a single project in a single place (being a Bintray package). This seems to correspond to how they share versions and other metadata.

@aalmiray aalmiray self-assigned this Jun 11, 2020
@aalmiray aalmiray added this to the 0.39.0 milestone Jun 11, 2020
@aalmiray
Copy link
Collaborator

I believe the gradle-plugin attribute is no longer needed if the standard Gradle plugin publication mechanism is used. Removing the use of this attribute in org.kordamp.gradle.plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants