Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown for file types at "Find Unlinked Files" should not contain .bib #547

Closed
koppor opened this issue Dec 23, 2021 · 10 comments · Fixed by JabRef/jabref#9318
Closed

Dropdown for file types at "Find Unlinked Files" should not contain .bib #547

koppor opened this issue Dec 23, 2021 · 10 comments · Fixed by JabRef/jabref#9318
Assignees
@Simone-Thai
Labels
feature good first issue small

Comments

@koppor
Copy link
Owner

koppor commented Dec 23, 2021

As user, I collect my papers as .pdf or .html, but not as .bib, because BibTeX is the meta data

grafik
@ThiloteE ThiloteE moved this to Free to take in Good First Issues Oct 14, 2022
@Simone-Thai
Copy link

Hi, could I be assigned to this issue?

@Simone-Thai
Copy link

Hi Koppor,
I'm planning to remove the BibTeX option and add in both the HTML and TXT standard file types, I was wondering about your thoughts on this?

@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Oct 25, 2022
@Simone-Thai
Copy link

I've noticed ImportHandler doesn't currently check html files. There currently isn't a method to parse a html file in EnternalFilesContentImporter and there are no importers for html files, however there is a citaviXmlImporter which may be relevant to this issue.
I believe that this is outside the scope of this issue, but I wanted a second opinion on this?

@koppor
Copy link
Owner Author

koppor commented Oct 26, 2022

Hi Koppor, I'm planning to remove the BibTeX option and add in both the HTML and TXT standard file types, I was wondering about your thoughts on this?

This is OK. Selection of multiple file types should be possible.

Additionally, *.md, should also be possible as Markdown becomes more and more prominent

@koppor
Copy link
Owner Author

koppor commented Oct 26, 2022

I've noticed ImportHandler doesn't currently check html files.

The file could just be linked without any other meta data.

however there is a citaviXmlImporter which may be relevant to this issue.

HTML is a a format with many options to put content in. There is no easy way to parse HTML. One could write a parser checking the <head> content of HTML. Contents such as title is standardized - and this could be read very easy. (See https://html.spec.whatwg.org/multipage/dom.html#metadata-content-2 for details)

For .txt, this is more complex.

@koppor
Copy link
Owner Author

koppor commented Oct 27, 2022

In case a file type is not recognized at import, the name of the file (without extension) should be used as title in BibTeX.

@Simone-Thai
Copy link

I've added a markdown file option:
Screen Shot 2022-10-28 at 4 05 13 pm
So far I've been working in the UnlinkedFilesDialogViewModel class but are there other areas that I need to work on too?

@Simone-Thai Simone-Thai mentioned this issue Oct 28, 2022
Merged
6 tasks
@Simone-Thai
Copy link

Hi Koppor,
I am planning to add an icon to the markdown file so I was wondering if you had any suggestions to go about this?

@Simone-Thai
Copy link

Simone-Thai commented Oct 28, 2022 •
edited
Loading

I've ended up adding a basic file icon to the dropdown, is this icon appropriate?
image

@koppor
Copy link
Owner Author

koppor commented Oct 28, 2022

Yes, its good. I have no other Markdown icon in mind (and I did not google :p)

@ThiloteE ThiloteE moved this from Reserved to In Progress in Good First Issues Oct 30, 2022
Repository owner moved this from In Progress to Done in Good First Issues Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simone-Thai Simone-Thai

Labels
feature good first issue small
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed BibTeX file type and included HTML and Markdown types
2 participants
@koppor @Simone-Thai