Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [RULES] False positive on hardcorded IP rule #646

Open
1 task done
abrugaro opened this issue Jul 11, 2024 · 3 comments
Open
1 task done

[BUG] [RULES] False positive on hardcorded IP rule #646

abrugaro opened this issue Jul 11, 2024 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Milestone
v0.5.0

Comments

@abrugaro
Copy link
Contributor

abrugaro commented Jul 11, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.5 beta 1

Tested with Kantra b0.5 beta1
Target: openjdk
Source: none
Source code used: https://github.com/openmrs/openmrs-core
Rule triggered: Hardcoded IP Address hardcoded-ip-address
Report: https://drive.google.com/file/d/12alisbavSvJ9-3O_8GNBkQ5-muk5Pgo

The rule is detecting ids and other elements like IPs.
This rule is also searching for IPs in comments.

image
image
@abrugaro abrugaro added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 11, 2024
@abrugaro abrugaro mentioned this issue Jul 11, 2024
Closed
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Jul 11, 2024
@shawn-hurley
Copy link
Contributor

This looks to me like a rule bug can we move to the rule set repo.

@abrugaro abrugaro changed the title [BUG] False positive on hardcorded IP rule [BUG] [RULES] False positive on hardcorded IP rule Jul 11, 2024
@abrugaro
Copy link
Contributor Author

Moved to konveyor/rulesets#83

@abrugaro abrugaro reopened this Jul 11, 2024
@dymurray dymurray added this to the v0.5.0 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
3 participants
@shawn-hurley @dymurray @abrugaro