Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited support for Python 3.5 #206

Open
mmaney opened this issue Aug 17, 2020 · 0 comments
Open

Limited support for Python 3.5 #206

mmaney opened this issue Aug 17, 2020 · 0 comments

Comments

@mmaney
Copy link
Collaborator

mmaney commented Aug 17, 2020

@mmaney has been trying out github's actions for running lint & tests against multiple Python versions, and there appear to be some issues with sewer and 3.5. This bug will serve to record what I find.

Python features (ssen in non-test sewer code)

  • f-strings, of course. the GH checks have found a number of them, and I'm rewriting them as I become aware of them.
  • comma after kwargs - this was caused by having the (obsolete) --py36 option for black, I think. That's been removed from sewer's setup & docs
  • underlines in numeric literals, pfui

Secondary issues

  • 3.5 doesn't accept type hints on variables. Workaround is to use hints in comments (or sometimes just to skip them)
  • black isn't compatible with 3.5, period. Workaround for the GH actions is to skip that as a requirement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant