New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automax: don't round down cpu count #479

Open

komuw opened this issue Oct 1, 2024 · 1 comment

Owner

komuw commented Oct 1, 2024

https://github.com/komuw/ong/blob/424f53c696d9f04b5451f11b8e916b096245a392/automax/automaxcpu.go#L63C14-L63C36

See: uber-go/automaxprocs#78

For containers with a fractional CPU limit between 1 and 2 cores, 
the current implementation rounds down GOMAXPROCS to 1, 
which means the container will never use more than 1s of CPU because it has a single active thread, 
and the VPA won't scale it up because it still has resources available.

maxProcs := int(math.Ceil(quota))

The text was updated successfully, but these errors were encountered:

Owner Author

komuw commented Oct 1, 2024

also: uber-go/automaxprocs#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment