fix InstalledVersionNum for windows build #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackattack01
force-pushed
the
zack/registry_install_version_builds
branch
from
23bdaf2
to
e6f6855
Compare
James-Pickett
approved these changes
Nov 26, 2024
RebeccaMahany
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous attempt at setting the
InstalledVersionNumdoes not work unless the proper kit/version value can be known and set ahead of build time by the packaging logic (e.g. only works when invoked from package-builder directly). To allow this logic to be included and built elsewhere, we can instead generate the VersionNum based on the detected version set in our packaging options