Skip to content
This repository has been archived by the owner on Dec 15, 2020. It is now read-only.

Fix string(int) issues for Go 1.15 compatibility #2286

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Fix string(int) issues for Go 1.15 compatibility #2286

merged 1 commit into from
Aug 19, 2020

Conversation

jalseth
Copy link
Contributor

@jalseth jalseth commented Aug 19, 2020

go vet in Golang 1.15 does not allow type casting from int to string. More info in golang/go#32479 and golang/go#3939.

Example output:

$ make test
go vet ./...
# github.com/kolide/fleet/server/datastore
server/datastore/datastore_labels_test.go:22:29: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
server/datastore/datastore_labels_test.go:22:40: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
make: *** [lint-go] Error 2

@zwass zwass merged commit b67cfc4 into kolide:master Aug 19, 2020
@zwass
Copy link
Contributor

zwass commented Aug 19, 2020

Thank you!

@jalseth jalseth deleted the fix-go1.15-issues branch August 19, 2020 20:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants