Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vector_sum_of_squares should only rescale for floating-point types, and should not use Scalar(1.0) or Scalar(0.0) otherwise #144

Open
mhoemmen opened this issue Jan 19, 2022 · 0 comments
Open

vector_sum_of_squares should only rescale for floating-point types, and should not use Scalar(1.0) or Scalar(0.0) otherwise #144

mhoemmen opened this issue Jan 19, 2022 · 0 comments

Comments

@mhoemmen
Copy link
Contributor

vector_sum_of_squares has the following issues:

  1. It does rescaling for all types, not just floating-point types (and complex-of-floating-point types).
  2. It attempts to construct Scalar(1.0) and Scalar(0.0) for all types.

See discussion here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhoemmen