Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to add margin around PDF #18

Open
srevinsaju opened this issue Jul 3, 2020 · 4 comments · May be fixed by #20
Open

Option to add margin around PDF #18

srevinsaju opened this issue Jul 3, 2020 · 4 comments · May be fixed by #20
Assignees
@aloisklink
Labels
enhancement New feature or request

Comments

@srevinsaju
Copy link

Is it possible to add a standard margin around the generated PDF? Thanks!
@maxarndt maxarndt added the enhancement New feature or request label Jul 3, 2020
@maxarndt
Copy link
Collaborator

maxarndt commented Jul 3, 2020

I think we should add this as a feature. The four margin properties could be set as an additional CLI option.

What do you think @kohheepeace @aloisklink?

@kohheepeace
Copy link
Owner

@maxarndt yes, agree 👍 Pass four side margin parameter in cli command.

@aloisklink
Copy link
Collaborator

👍 from me too, I'm happy to implement it this weekend, unless anyone else particularly wants to?

Maybe it's also worth adding a page size option, since in the US they usually use US Letter, not A4.

@aloisklink aloisklink self-assigned this Jul 3, 2020
@kohheepeace
Copy link
Owner

@aloisklink yay!🎉

aloisklink added a commit to aloisklink/docusaurus-pdf that referenced this issue Jul 5, 2020
@aloisklink
feat: Allow setting the margin and format of PDF
6652068 
Adds the --format and --margin field to specify the formatting
of the PDF file, and adds tests to make sure we don't break anything.

Additionally, allows setting --no-sandbox on all commands, including
the default docusaurus command.

Fixes kohheepeace#18.
@aloisklink aloisklink linked a pull request Jul 5, 2020 that will close this issue
Open
aloisklink added a commit to aloisklink/docusaurus-pdf that referenced this issue Jul 7, 2020
@aloisklink
feat: Allow setting the margin and format of PDF
04cdcf1 
Adds the --format and --margin field to specify the formatting
of the PDF file, and adds tests to make sure we don't break anything.

Additionally, allows setting --no-sandbox on all commands, including
the default docusaurus command.

Fixes kohheepeace#18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aloisklink aloisklink

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to pick PDF margins and format (A4/A3/etc.) aloisklink/docusaurus-pdf
4 participants
@maxarndt @aloisklink @kohheepeace @srevinsaju