-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window resizing behavior broken in HEAD #643
Comments
The various combination of window resizing seems to work fine for me, I am unable to reproduce the issue you described. Assuming the following layout:
|
@#%^!!! This was another case of PEBCAK. I looked at this again with fresh eyes and realized that after a refactor my top/bottom resizes were using the X segment, not the Y. Sorry for wasting your time. For clarity, I was having issues with the A/B and C/D borders, what I was referring to as the "interior", or bsp fence. The non-touching "exterior" edge being the top edge of A or bottom edge of B, for example, and I'm using the OR catch in that case. Here is my code, although I'm using Hammerspoon: function yabaiMsg(scope, param, fallbackParam)
local planA = string.format("%s -m %s --%s", yabaiPath, scope, param)
local cmd = ''
if fallbackParam==nil then
cmd = planA
else
local planB = string.format("%s -m %s --%s", yabaiPath, scope, fallbackParam)
cmd = string.format("%s || %s", planA, planB)
end
print(cmd)
os.execute(cmd)
end Fixed and functional code for resizes (hyperWindowResize is one of my "modes" in Hammerspoon: -- Yabai window resizing targets an edge that is adjacent to other windows
-- Using the OR operator allows thinking in terms of the window division
-- and letting "error handling" conduct the logical operation regardless of
-- window focus and relative internal edge.
hyperWindowResize:bind('', 'h', function() yabaiMsg( 'window', 'resize right:-30:0', 'resize left:-30:0' ) end)
hyperWindowResize:bind('', 'l', function() yabaiMsg( 'window', 'resize right:30:0', 'resize left:30:0' ) end)
hyperWindowResize:bind('', 'j', function() yabaiMsg( 'window', 'resize top:0:30', 'resize bottom:0:30' ) end)
hyperWindowResize:bind('', 'k', function() yabaiMsg( 'window', 'resize top:0:-30', 'resize bottom:0:-30' ) end) |
I just updated to the latest HEAD and my vertical window resizing hotkeys are no longer working. I can still resize left and right fine, but top and bottom don't have any effect. If I run yabai in verbose mode, I can see the "cannot locate a bsp node fence" error if I resize by exterior edge, but if I resize by the interior edge there's no error and no effect.
Sorry, I don't know what commit I was on prior to this update, but I had updated from 3.2.1 to HEAD around two or three weeks ago and resizing was working.
The text was updated successfully, but these errors were encountered: