Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window_border on results in blurred screen sharing in Slack #1471

Closed
rickythefox opened this issue Sep 30, 2022 · 9 comments
Closed

window_border on results in blurred screen sharing in Slack #1471

rickythefox opened this issue Sep 30, 2022 · 9 comments

Comments

@rickythefox
Copy link

rickythefox commented Sep 30, 2022

A bit of a weird issue here.

When yabai is configured with window_border on and you share you screen during a Slack call the whole screen is blurred. Setting window_border off removes the blur. This used to work fine in 4.x versions.

image

@cherche
Copy link

cherche commented Sep 30, 2022

As of 5.x, window border also includes a blur behind each window. This is only really noticeable with non-opaque windows, so if you've left active_window_opacity and normal_window_opacity as 1.0, you likely would not have noticed this underlay.

Try setting yabai -m config window_border_blur off. I'm not familiar enough with yabai to know if it's possible to auatomatically disable window_blur for select windows using rules.

@rickythefox
Copy link
Author

@cherche thanks, that worked! Would be nice to be able to disable the blur for select windows, like slack screen sharing.

@cherche
Copy link

cherche commented Oct 2, 2022

@rickythefox Just did a quick read of the docs and there is a way to automate this with rules, as long as it's possible to target the Slack screen sharing window:

yabai -m rule --add app="^Slack$" title="Window Title" border=off

You'll need to query windows (yabai -m query --windows) to see what info would uniquely identify Slack's screen sharing window.

@prdanelli
Copy link

I have a similar issue to this, but for MacOS's Mission Control (Show open windows).

Borders on:
image

Borders off:

image

I have a shortcut to toggle the borders, but for stuff like screensharing in Slack, using mission control etc it feels like it might constitute bug.

@Allaman
Copy link

Allaman commented Nov 7, 2022

This happend to me when recording my screen with CleanshotX as well! yabai -m config window_border_blur off or yabai -m config window_border off solves the issue.

@dominiklohmann
Copy link
Collaborator

You should be able to detect these windows and to disable borders for them using a rule1, e.g.,

# Disable borders for all Slack windows that are not standard windows.
yabai -m rule--add app=^Slack$ subrole!=AXStandardWindow border=off

If you want to investigate this a bit further, I recommend using yabai -m query --windows to understand the unique characteristics of windows causing you issues. The problem here really is Slack creating a fully transparent window when screen sharing; yabai cannot possibly account for all edge cases like this.

Footnotes

  1. https://github.com/koekeishiya/yabai/blob/master/doc/yabai.asciidoc#rule

@ArtemSmaznov
Copy link

You should be able to detect these windows and to disable borders for them using a rule1, e.g.,

# Disable borders for all Slack windows that are not standard windows.
yabai -m rule--add app=^Slack$ subrole!=AXStandardWindow border=off

If you want to investigate this a bit further, I recommend using yabai -m query --windows to understand the unique characteristics of windows causing you issues. The problem here really is Slack creating a fully transparent window when screen sharing; yabai cannot possibly account for all edge cases like this.

Footnotes

  1. https://github.com/koekeishiya/yabai/blob/master/doc/yabai.asciidoc#rule

Looks like the transparent window is AXStandardWindow as well - I get 2 extra slack entries in the query. Or maybe those are something else and the transparent one is not detected as the extra ones have level that is not 0 as opposed to the main window but yabai -m rule --add app="Slack" level!=0 border=off doesn't affect the screenshare. Guess will need to play around with different parameters some more

@ricardoraposo
Copy link

I also managed to solve this problem by turning off the window_topmost setting

yabai -m config window_topmost               off

@koekeishiya
Copy link
Owner

Borders have been removed in the latest release (v6.0.0) (#1889) because of multiple issues present in both Ventura and Sonoma.

window_topmost has also been removed, and equivalent functionality has been introduced in a robust way #1887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants