Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK-1165] Fix project header title serving old asset name #5174

Conversation

magicznyleszek
Copy link
Member

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Run ./python-format.sh to make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes
  8. Create a testing plan for the reviewer and add it to the Testing section

Description

Fixes a problem when editing project title using top header - after successful update API call, component was reverting back to old name. This was a bug in the UI, database was storing the updated name - it was possible to overwrite the updated name due to confusing bug in the UI though.

Notes

For some reason this component was using props name when successful API call response was received - instead of relying on the response data. There still is a risko of bugs due to asset cache, so I left a comment for future debugger. I was testing out UI to try to break it and didn't find any bug as of yet.

Testing

Try changing title using header editor. See video at #5170

Related issues

Fixes #5170

Copy link

@magicznyleszek magicznyleszek marked this pull request as ready for review October 16, 2024 16:13
@p2edwards p2edwards merged commit 919b78b into release/2.024.33 Oct 18, 2024
7 checks passed
@p2edwards p2edwards deleted the release-2.024.33-task-1165-project-header-title-bugfix branch October 18, 2024 19:12
Copy link
Contributor

@p2edwards p2edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tested and approved.

Additional internal discussion here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants