Django 2 Upgrade (part 3): Force explicitly "on_delete" for foreign keys. #2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
changed the base branch from
2489-drop-python2-support
to
python3-upgrade
noliveleger
changed the title
noliveleger
changed the title
noliveleger
changed the title
noliveleger
changed the base branch from
python3-upgrade
to
2489-drop-python2-support
|
Great, so this just continues the same behavior that we had under Django 1.8: https://docs.djangoproject.com/en/1.8/ref/models/fields/#django.db.models.ForeignKey.on_delete
|
jnm
approved these changes
Nov 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains only changes related to required argument
on_deleteforForeignKeys.The default behaviour in Django 1.x was on
CASCADE.On top of #2504