Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving away from deprecated, problematic terminology #10

Open
samdbmg opened this issue Sep 18, 2020 · 0 comments
Open

Consider moving away from deprecated, problematic terminology #10

samdbmg opened this issue Sep 18, 2020 · 0 comments

Comments

@samdbmg
Copy link
Contributor

samdbmg commented Sep 18, 2020

The Jenkins project moved away from using the term "slave" in 2016, preferring the term "agent" instead.

This repository talks about Jenkins "slaves" in a few places that wouldn't be that difficult to change:

  • Names of tasks, handlers etc.
  • The README
  • Variables used within the role such as the systemd unit template
  • Names of some of the role files

More difficult is the default variables, but defaults/main.yml could be amended to something along these lines to avoid a breaking change:

jenkins_agent_user: {{ jenkins_slave_user }}
jenkins_slave_user: jenkins

Would you be happy to take a PR changing the terminology? There's also the name of the role itself which might be a more difficult change, because I'm not sure how Ansible Galaxy would behave if you renamed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant