diff --git a/pkg/ccl/spanconfigccl/spanconfigkvaccessorccl/kvaccessor_test.go b/pkg/ccl/spanconfigccl/spanconfigkvaccessorccl/kvaccessor_test.go index 7eac54478954..1d40978d269e 100644 --- a/pkg/ccl/spanconfigccl/spanconfigkvaccessorccl/kvaccessor_test.go +++ b/pkg/ccl/spanconfigccl/spanconfigkvaccessorccl/kvaccessor_test.go @@ -39,7 +39,7 @@ func TestCommitTSIntervals(t *testing.T) { var i interceptor ts, _, _ := serverutils.StartServer(t, base.TestServerArgs{ // Manually starts a tenant below. No need to start one here. - DefaultTestTenant: base.TODOTestTenantDisabled, + DefaultTestTenant: base.TestControlsTenantsExplicitly, Knobs: base.TestingKnobs{ Server: &server.TestingKnobs{ WallClock: manual, diff --git a/pkg/ccl/spanconfigccl/spanconfigreconcilerccl/datadriven_test.go b/pkg/ccl/spanconfigccl/spanconfigreconcilerccl/datadriven_test.go index 6dc86e486a64..692355532506 100644 --- a/pkg/ccl/spanconfigccl/spanconfigreconcilerccl/datadriven_test.go +++ b/pkg/ccl/spanconfigccl/spanconfigreconcilerccl/datadriven_test.go @@ -99,9 +99,7 @@ func TestDataDriven(t *testing.T) { } tc := testcluster.StartTestCluster(t, 1, base.TestClusterArgs{ ServerArgs: base.TestServerArgs{ - // Test fails when run under the default test tenant. More - // investigation is required. - DefaultTestTenant: base.TODOTestTenantDisabled, + DefaultTestTenant: base.TestControlsTenantsExplicitly, Knobs: base.TestingKnobs{ JobsTestingKnobs: jobs.NewTestingKnobsWithShortIntervals(), // speeds up test SpanConfig: scKnobs, diff --git a/pkg/ccl/spanconfigccl/spanconfigsplitterccl/datadriven_test.go b/pkg/ccl/spanconfigccl/spanconfigsplitterccl/datadriven_test.go index 4ebf55724dd2..09317a1016c9 100644 --- a/pkg/ccl/spanconfigccl/spanconfigsplitterccl/datadriven_test.go +++ b/pkg/ccl/spanconfigccl/spanconfigsplitterccl/datadriven_test.go @@ -67,8 +67,8 @@ func TestDataDriven(t *testing.T) { datadriven.Walk(t, datapathutils.TestDataPath(t), func(t *testing.T, path string) { tc := testcluster.StartTestCluster(t, 1, base.TestClusterArgs{ ServerArgs: base.TestServerArgs{ - // Fails with nil pointer dereference. Tracked with #76378. - DefaultTestTenant: base.TODOTestTenantDisabled, + // Fails with nil pointer dereference. Tracked with #76378 and #106818. + DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(106818), Knobs: base.TestingKnobs{ SpanConfig: scKnobs, }, diff --git a/pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl/datadriven_test.go b/pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl/datadriven_test.go index 9d5e807df58c..143720a6ea8f 100644 --- a/pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl/datadriven_test.go +++ b/pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl/datadriven_test.go @@ -109,9 +109,8 @@ func TestDataDriven(t *testing.T) { datadriven.Walk(t, datapathutils.TestDataPath(t), func(t *testing.T, path string) { tc := testcluster.StartTestCluster(t, 1, base.TestClusterArgs{ ServerArgs: base.TestServerArgs{ - // Test fails when run within a tenant. More investigation - // is required. Tracked with #76378. - DefaultTestTenant: base.TODOTestTenantDisabled, + // Fails with nil pointer dereference. Tracked with #76378 and #106818. + DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(106818), Knobs: base.TestingKnobs{ GCJob: gcTestingKnobs, SpanConfig: scKnobs, diff --git a/pkg/ccl/spanconfigccl/spanconfigsqlwatcherccl/sqlwatcher_test.go b/pkg/ccl/spanconfigccl/spanconfigsqlwatcherccl/sqlwatcher_test.go index d7022b0999cf..926c58ab5452 100644 --- a/pkg/ccl/spanconfigccl/spanconfigsqlwatcherccl/sqlwatcher_test.go +++ b/pkg/ccl/spanconfigccl/spanconfigsqlwatcherccl/sqlwatcher_test.go @@ -60,9 +60,8 @@ func TestSQLWatcherReactsToUpdates(t *testing.T) { defer dirCleanupFn() tc := testcluster.StartTestCluster(t, 1, base.TestClusterArgs{ ServerArgs: base.TestServerArgs{ - ExternalIODir: dir, - // Test already runs from a tenant. - DefaultTestTenant: base.TODOTestTenantDisabled, + ExternalIODir: dir, + DefaultTestTenant: base.TestControlsTenantsExplicitly, Knobs: base.TestingKnobs{ SpanConfig: &spanconfig.TestingKnobs{ ManagerDisableJobCreation: true, // disable the automatic job creation. @@ -288,8 +287,7 @@ func TestSQLWatcherMultiple(t *testing.T) { tc := testcluster.StartTestCluster(t, 1, base.TestClusterArgs{ ServerArgs: base.TestServerArgs{ - // Test already runs from a tenant. - DefaultTestTenant: base.TODOTestTenantDisabled, + DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(106821), Knobs: base.TestingKnobs{ SpanConfig: &spanconfig.TestingKnobs{ ManagerDisableJobCreation: true, // disable the automatic job creation. @@ -307,7 +305,7 @@ func TestSQLWatcherMultiple(t *testing.T) { noopCheckpointDuration := 100 * time.Millisecond sqlWatcher := spanconfigsqlwatcher.New( - keys.SystemSQLCodec, + ts.Codec(), ts.ClusterSettings(), ts.RangeFeedFactory().(*rangefeed.Factory), 1<<20, /* 1 MB, bufferMemLimit */ @@ -420,8 +418,7 @@ func TestSQLWatcherOnEventError(t *testing.T) { tc := testcluster.StartTestCluster(t, 1, base.TestClusterArgs{ ServerArgs: base.TestServerArgs{ - // Test already runs from a tenant. - DefaultTestTenant: base.TODOTestTenantDisabled, + DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(106821), Knobs: base.TestingKnobs{ SpanConfig: &spanconfig.TestingKnobs{ ManagerDisableJobCreation: true, // disable the automatic job creation. @@ -438,7 +435,7 @@ func TestSQLWatcherOnEventError(t *testing.T) { tdb.Exec(t, `SET CLUSTER SETTING kv.closed_timestamp.target_duration = '100ms'`) sqlWatcher := spanconfigsqlwatcher.New( - keys.SystemSQLCodec, + ts.Codec(), ts.ClusterSettings(), ts.RangeFeedFactory().(*rangefeed.Factory), 1<<20, /* 1 MB, bufferMemLimit */ @@ -471,8 +468,7 @@ func TestSQLWatcherHandlerError(t *testing.T) { tc := testcluster.StartTestCluster(t, 1, base.TestClusterArgs{ ServerArgs: base.TestServerArgs{ - // Test already runs from a tenant. - DefaultTestTenant: base.TODOTestTenantDisabled, + DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(106821), Knobs: base.TestingKnobs{ SpanConfig: &spanconfig.TestingKnobs{ ManagerDisableJobCreation: true, // disable the automatic job creation. @@ -490,7 +486,7 @@ func TestSQLWatcherHandlerError(t *testing.T) { noopCheckpointDuration := 100 * time.Millisecond sqlWatcher := spanconfigsqlwatcher.New( - keys.SystemSQLCodec, + ts.Codec(), ts.ClusterSettings(), ts.RangeFeedFactory().(*rangefeed.Factory), 1<<20, /* 1 MB, bufferMemLimit */ @@ -549,8 +545,7 @@ func TestWatcherReceivesNoopCheckpoints(t *testing.T) { tc := testcluster.StartTestCluster(t, 1, base.TestClusterArgs{ ServerArgs: base.TestServerArgs{ - // Test already runs from a tenant. - DefaultTestTenant: base.TODOTestTenantDisabled, + DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(106821), Knobs: base.TestingKnobs{ SpanConfig: &spanconfig.TestingKnobs{ ManagerDisableJobCreation: true, // disable the automatic job creation. @@ -568,7 +563,7 @@ func TestWatcherReceivesNoopCheckpoints(t *testing.T) { noopCheckpointDuration := 25 * time.Millisecond sqlWatcher := spanconfigsqlwatcher.New( - keys.SystemSQLCodec, + ts.Codec(), ts.ClusterSettings(), ts.RangeFeedFactory().(*rangefeed.Factory), 1<<20, /* 1 MB, bufferMemLimit */