We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What happened?
Screenshots and stack traces:
My environment:
php -v
composer show laravel/framework
composer show laravel/lumen-framework
composer show knuckleswtf/scribe
Additional info: In my case, I changed GetFromLaravelAPI.php to the following and it worked fine.
scribe/src/Extracting/Strategies/UrlParameters/GetFromLaravelAPI.php
Line 69 in 4b59fb9
$typeName = $argumentInstance->getKeyName() === $argumentInstance->getRouteKeyName() ? $argumentInstance->getKeyType() : 'string'; $type = $this->normalizeTypeName($typeName);
The text was updated successfully, but these errors were encountered:
Sure, send in a PR. But what does the route key method return for people who haven't defined it for their model?
Sorry, something went wrong.
Thank you for your quick response. I'll send PR.
what does the route key method return for people who haven't defined it for their model?
Base model return key name. So I don't think it will affect the people who haven't defined it.
https://github.com/laravel/framework/blob/6a3ddf21096b1801d9e7f221f72ae78d90eb3622/src/Illuminate/Database/Eloquent/Model.php#L1786
public function getRouteKeyName() { return $this->getKeyName(); }
Cool, should be easy to send in a PR then.
Successfully merging a pull request may close this issue.
What happened?
Screenshots and stack traces:
My environment:
php -v
): 8.0.3composer show laravel/framework
orcomposer show laravel/lumen-framework
): v8.49.0composer show knuckleswtf/scribe
): 3.3.2Additional info:
In my case, I changed GetFromLaravelAPI.php to the following and it worked fine.
scribe/src/Extracting/Strategies/UrlParameters/GetFromLaravelAPI.php
Line 69 in 4b59fb9
The text was updated successfully, but these errors were encountered: