#422 use foreignObject/div to place actor label in sequence diagram #423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #422, the change to foreignObject/div is enabled by config.textPlacement: fo. Otherwise, use svg text as before without foreignObject.
_drawTextCandidateFunc may be generalized and used elsewhere in sequence diagram and beyond. there is opportunity to consolidate toward to some common code for text placement.
pased: npm run tape && npm run karma && npm run dist
npm run jasmine was failing unrelated to this change.
manually tested:
the change may go further to consolidate
\n support.
please let me know if it's better keep going with in this PR, or new PR after the current changeset is satisfied and merged.