add line interpolation to linkStyle in flowchart #346
Merged
+339
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Well done, I like the refactoring. Important to keep things from deteriorating over time. |
|
Thanks for this. Am I right that it hasn't show up in a release yet? |
mgenereu
pushed a commit
to mgenereu/mermaid
that referenced
this pull request
Jun 25, 2022
…evelop/node-16.8.0 chore(deps): bump node from 14.17.0 to 16.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for issue #335
Adds an (optional) item to linkStyle to pass through the line interpolation selection to dagre-d3, for "default" or a numbered link, with or without a trailing CSS style, e.g.
Running
gulp jisonof course updated all of the parser output files, but I only modified flow.jison / flow.js so only that is included. Happy to include the others if that's preferred.Also I did a little refactoring of flowRenderer.js addEdges() because otherwise the "if" tree would have gotten out of hand.
Comments / suggestions welcome.