Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narrow down console logging when flowchart subgraphs are added #1782

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Narrow down console logging when flowchart subgraphs are added #1782

merged 1 commit into from
Nov 17, 2020

Conversation

GDFaber
Copy link
Member

@GDFaber GDFaber commented Nov 17, 2020

📑 Summary

Adding flowchart subgraphs is now only logged at log level "info" (2).

Resolves #1742

📏 Design Decisions

Replaced console.log(...) with logger.info(...).

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Nov 17, 2020
@GDFaber GDFaber merged commit dfa306c into develop Nov 17, 2020
@knsv knsv deleted the bug/1742_replace_console_log_with_logger_info branch January 27, 2021 20:26
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Console log in release
1 participant
@GDFaber