Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Dynamic Settings #15

Merged
merged 70 commits into from
May 1, 2023

Conversation

davidshq
Copy link
Collaborator

Dynamic Settings

  • Add two new models: setting and settings_group (these hold and group the dynamic settings).
  • Use the built-in Python logging library in Project model and tasks.py.
  • Fields added to the Project model that map to the Settings model.
  • Remove default_identified_artifacts and pass an empty array at the global level instead.
  • Modify tasks.py so that it can use the dynamic settings for determining the learning models to load.
  • Add a setting.json file which contains a base configuration for MIQA that can be imported when setting up a new instance.

Misc

  • Add an AUTO_ADVANCE flag which determines whether scans advanced automatically after a decision is rendered.
  • Update GitHub Actions yaml files to use most recent versions of actions available atm.
  • Disabling Playwright temporarily from CI due to need to setup backend for frontend testing.
  • Update .gitattributes to fix some issues with some binary files being detected as changed even when they aren't.
  • Exclude test files from extraneous dependencies ESLint rule.

davidshq added 30 commits April 12, 2023 14:54

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
getData -> getImageData
getArrayName -> getArrayNameFromFilename
i => experimentIndex
j => scanIndex
ADD_SCAN_DECISION
- currentScan -> currentScanId
- newDecision -> newScanDecision

SET_FRAME_EVALUATION
- evaluation -> frameEvaluation
SET_LOADING_FRAME
value -> isLoading

SET_ERROR_LOADING_FRAME
value -> isErrorLoading

ADD_SCAN_FRAMES
sid -> scanId
id -> frameId

ADD_EXPERIMENT_SCANS
eid -> experimentId
sId -> scanId
ADD_EXPERIMENT
id -> experimentId
value -> experiment

Removing setCurrentWindowWidth and setCurrentWindowLevel
loadProject
i -> experimentIndex
id -> experimentId
value -> experiment
j -> scanIndex
…rviews and createProject...

switchReviewMode -> SET_REVIEW_MODE
setProjects -> SET_PROJECTS
setCurrentProject -> SET_CURRENT_PROJECT
…iable names newExp, oldExp to newExperimentId, oldExperimentId
…om artifacts, replacing currentViewData with currentFrame to avoid unnecessary clearing of confirmedPresent/Absent, renaming state to match Vuex store, awaiting taskOverview, renaming DecisionButtons to ControlPanelDecision
@davidshq davidshq requested a review from annehaley April 28, 2023 20:16
@davidshq
Copy link
Collaborator Author

@annehaley - this one should be ready to go except that for some reason the CI is having trouble finding itk. not sure if you have any ideas? I reverted the github actions I'd updated but that doesn't seem to have resolved the issue

@davidshq davidshq changed the title WIP: Integrate Dynamic Settings Integrate Dynamic Settings May 1, 2023
Comment on lines 61 to 63
// TODO: Passed in from Python as { results: {}, evaluation_model: string }
frame_evaluation?: string,
// TODO: Also has download_url
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When serialized, the frame_evaluation field is passed to the webapp as the id of the FrameEvaluation object; it's not nested into the response. Instead, we use subsequent requests for the target FrameEvaluations using the id, which is a UUID string.

Comment on lines 7 to 10
// TODO: Throughout we have snake case properties, these
// could be converted to camel case using:
// https://morioh.com/p/8e8b33c25ea1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use snake case in the type file because that is how the keys are written when they are received from the backend, therefore request responses have snake case keys

@annehaley annehaley force-pushed the dynamic-settings2 branch from b0f3725 to cbb81ba Compare May 1, 2023 14:23
setting.json Outdated Show resolved Hide resolved
@annehaley annehaley force-pushed the dynamic-settings2 branch from 31460fa to 0dfa4c5 Compare May 1, 2023 17:41
@annehaley annehaley merged commit 21643c5 into knowledgevis:master May 1, 2023
@annehaley annehaley deleted the dynamic-settings2 branch May 3, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants