-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Dynamic Settings #15
Conversation
getData -> getImageData getArrayName -> getArrayNameFromFilename
i => experimentIndex j => scanIndex
ADD_SCAN_DECISION - currentScan -> currentScanId - newDecision -> newScanDecision SET_FRAME_EVALUATION - evaluation -> frameEvaluation
SET_LOADING_FRAME value -> isLoading SET_ERROR_LOADING_FRAME value -> isErrorLoading ADD_SCAN_FRAMES sid -> scanId id -> frameId ADD_EXPERIMENT_SCANS eid -> experimentId sId -> scanId
ADD_EXPERIMENT id -> experimentId value -> experiment Removing setCurrentWindowWidth and setCurrentWindowLevel
loadProject i -> experimentIndex id -> experimentId value -> experiment j -> scanIndex
…rviews and createProject... switchReviewMode -> SET_REVIEW_MODE setProjects -> SET_PROJECTS setCurrentProject -> SET_CURRENT_PROJECT
…oving unused saveSlice from VtkViewer
…iable names newExp, oldExp to newExperimentId, oldExperimentId
…om artifacts, replacing currentViewData with currentFrame to avoid unnecessary clearing of confirmedPresent/Absent, renaming state to match Vuex store, awaiting taskOverview, renaming DecisionButtons to ControlPanelDecision
@annehaley - this one should be ready to go except that for some reason the CI is having trouble finding itk. not sure if you have any ideas? I reverted the github actions I'd updated but that doesn't seem to have resolved the issue |
web_client/src/types.ts
Outdated
// TODO: Passed in from Python as { results: {}, evaluation_model: string } | ||
frame_evaluation?: string, | ||
// TODO: Also has download_url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When serialized, the frame_evaluation
field is passed to the webapp as the id of the FrameEvaluation
object; it's not nested into the response. Instead, we use subsequent requests for the target FrameEvaluation
s using the id, which is a UUID string.
web_client/src/types.ts
Outdated
// TODO: Throughout we have snake case properties, these | ||
// could be converted to camel case using: | ||
// https://morioh.com/p/8e8b33c25ea1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use snake case in the type file because that is how the keys are written when they are received from the backend, therefore request responses have snake case keys
b0f3725
to
cbb81ba
Compare
31460fa
to
0dfa4c5
Compare
Dynamic Settings
setting
andsettings_group
(these hold and group the dynamic settings).logging
library in Project model andtasks.py
.default_identified_artifacts
and pass an empty array at the global level instead.tasks.py
so that it can use the dynamic settings for determining the learning models to load.setting.json
file which contains a base configuration for MIQA that can be imported when setting up a new instance.Misc
.gitattributes
to fix some issues with some binary files being detected as changed even when they aren't.