New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace import.meta.url, _filename, and _dirname appropriately #42

Closed

knightedcodemonkey opened this issue May 24, 2024 · 1 comment · Fixed by #44

Labels

bug

Owner

knightedcodemonkey commented May 24, 2024

When the dual build is CJS

Replace import.meta.url with something like require('url').pathToFileURL(__filename).toString().

When the dual build is ESM

Repalce __filename with import.meta.filename or fileURLToPath(import.meta.url). The latter option allows supporting older node versions.
Replace __dirname with import.meta.dirname or dirname(fileURLToPath(import.meta.url)).

https://nodejs.org/api/esm.html#no-__filename-or-__dirname

The text was updated successfully, but these errors were encountered:

knightedcodemonkey added the bug label

Owner Author

knightedcodemonkey commented May 25, 2024

Interesting tsc behavior filed in TypeScript/58658.

knightedcodemonkey mentioned this issue

feat: transform module globals before compiling with tsc. #44

Merged

knightedcodemonkey closed this as completed in #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment