Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestSingleConcurrency is flake #2306

Closed
bbrowning opened this issue Oct 24, 2018 · 1 comment · Fixed by #2308
Closed

TestSingleConcurrency is flake #2306

bbrowning opened this issue Oct 24, 2018 · 1 comment · Fixed by #2308
Assignees
@bbrowning
Labels
area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/bug Categorizes issue or PR as related to a bug.

Comments

@bbrowning
Copy link
Contributor

The recently added TestSingleConcurrency has flaked once in recent runs. After running it in a loop locally, I've been able to reproduce the flake. The test waits for the Revision to be ready but also needs to check for Route readiness and probe the route to ensure we receive at least 1 successful response before firing off the concurrent tests.
@knative-prow-robot knative-prow-robot added area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/bug Categorizes issue or PR as related to a bug. labels Oct 24, 2018
@bbrowning
Copy link
Contributor Author

/assign

@bbrowning bbrowning mentioned this issue Oct 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbrowning bbrowning

Labels
area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wait for Route readiness in TestSingleConcurrency bbrowning/serving
2 participants
@bbrowning @knative-prow-robot