Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Istio image tags into digests #2087

Closed
tcnghia opened this issue Sep 26, 2018 · 4 comments
Closed

Resolve Istio image tags into digests #2087

tcnghia opened this issue Sep 26, 2018 · 4 comments
Assignees
@jonjohnsonjr
Labels
area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features

Comments

@tcnghia
Copy link
Contributor

tcnghia commented Sep 26, 2018

Expected Behavior

Our provided Istio manifests should refer to digests and not tags. We have seen cases where a moving tag (latest) causes changing behavior.

Our script https://github.com/knative/serving/blob/master/third_party/istio-1.0.2/download-istio.sh should just do ko resolve after running helm.

Actual Behavior

We are using tags in the provided manifest.

Steps to Reproduce the Problem

  1. See manifest here https://github.com/knative/serving/blob/master/third_party/istio-1.0.2/istio.yaml which has tags.

Additional Info

/cc @rgregg @mattmoor
@knative-prow-robot knative-prow-robot added area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/good-first-issue labels Sep 26, 2018
@mattmoor
Copy link
Member

/assign @jonjohnsonjr

Feels like a good use of ggcr

@mattmoor mattmoor added this to the Ice Box milestone Nov 27, 2018
@jonjohnsonjr
Copy link
Contributor

Got a prototype of this running, but we need to support pulling schema 1 images, since some of the images referenced by the istio yamls are schema 1 (the quay ones).

@jonjohnsonjr
Copy link
Contributor

jonjohnsonjr commented Feb 20, 2019 •
edited
Loading

Blocked by google/go-containerregistry#377
Blocked by https://github.com/google/go-containerregistry/issues/379

@tcnghia
Copy link
Contributor Author

tcnghia commented Sep 20, 2019

We no longer publish Istio's manifests

@tcnghia tcnghia closed this as completed Sep 20, 2019
@dprotaso dprotaso removed this from the Ice Box milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonjohnsonjr jonjohnsonjr

Labels
area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dprotaso @tcnghia @mattmoor @jonjohnsonjr @knative-prow-robot