Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-contour: rate limiting in contour HTTP Proxy spec #13033

Closed
pramenn opened this issue Jun 13, 2022 · 8 comments
Closed

net-contour: rate limiting in contour HTTP Proxy spec #13033

pramenn opened this issue Jun 13, 2022 · 8 comments
Labels
area/networking kind/feature Well-understood/specified features, ready for coding. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@pramenn
Copy link

pramenn commented Jun 13, 2022

Describe the feature

I am currently using net contour controller config which does not support enabling rate limiting in contour HTTP Proxy spec for my knative services.

Http Proxy with global rate limiting example: https://projectcontour.io/docs/v1.21.0/config/rate-limiting/#global-rate-limiting
Contour rate limiting design doc: https://github.com/projectcontour/contour/blob/main/design/ratelimit-design.md

configmap config-contour in knative-serving namespace should support contour HTTP Proxy rate liming spec.

@pramenn pramenn added the kind/feature Well-understood/specified features, ready for coding. label Jun 13, 2022
@pramenn
Copy link
Author

pramenn commented Jun 13, 2022

/area networking

@nak3
Copy link
Contributor

nak3 commented Jun 14, 2022

This is related to knative-extensions/net-kourier#759 (rate limiting for net-kourier).

What I am still debating is whether we should add it as a common API or not.
I keep watching Gateway API's discussion kubernetes-sigs/gateway-api#326 (as we will use the API in the future), but they also do not have the conclusion yet.

@pramenn
Copy link
Author

pramenn commented Jun 14, 2022

@nak3 Thanks.

PR is for net-kourier but I am using net-contour. Besides, PR only supports local rate limiting, is implementing global rate limiting descriptor on the roadmap?

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 13, 2022
@knative-prow-robot
Copy link
Contributor

This issue or pull request is stale because it has been open for 90 days with no activity.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close

/lifecycle stale

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 14, 2022
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 13, 2023
@knative-prow-robot
Copy link
Contributor

This issue or pull request is stale because it has been open for 90 days with no activity.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close

/lifecycle stale

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2023
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking kind/feature Well-understood/specified features, ready for coding. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants