You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd like to be able to embed knative/pkg types as protobufs. This is common with kubernetes types recently using go-to-protobuf, autogenerating the proto from the base Go type. (example - core/v1).
Actual Behavior
No protobufs exist. :(
Additional Info
I've tried playing around with go-to-protobuf generation for knative.dev/pkg/apis, but the automatic generation seems to have trouble with the apis.URL type, since it tries to generate the underlying url.URL struct. I tried to resolve this with a custom marshaller, but ran into issues (likely related to gogo/protobuf#678).
Changing the apis.URL type to a string with helper methods to convert into a url.URL might help ease proto generation while being compatible with exist API json/yaml formats, but I'm not sure if this will be considered a breaking change subject to the deprecation policy.
The text was updated successfully, but these errors were encountered:
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
Expected Behavior
I'd like to be able to embed knative/pkg types as protobufs. This is common with kubernetes types recently using go-to-protobuf, autogenerating the proto from the base Go type. (example - core/v1).
Actual Behavior
No protobufs exist. :(
Additional Info
I've tried playing around with
go-to-protobuf
generation forknative.dev/pkg/apis
, but the automatic generation seems to have trouble with the apis.URL type, since it tries to generate the underlying url.URL struct. I tried to resolve this with a custom marshaller, but ran into issues (likely related to gogo/protobuf#678).Sample command:
Changing the
apis.URL
type to a string with helper methods to convert into aurl.URL
might help ease proto generation while being compatible with exist API json/yaml formats, but I'm not sure if this will be considered a breaking change subject to the deprecation policy.The text was updated successfully, but these errors were encountered: