From 83b915626e624cb721280dab22265e4356a4801a Mon Sep 17 00:00:00 2001 From: Knative Prow Robot Date: Thu, 9 Nov 2023 19:04:42 +0000 Subject: [PATCH] [release-1.12] :bug: Set latest release only when publishing to Github (#348) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Don't set latest release when not publishing to GH * Add explanation Co-authored-by: kmahapatra --------- Co-authored-by: Chris Suszyński Co-authored-by: Chris Suszynski Co-authored-by: kmahapatra --- release.sh | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/release.sh b/release.sh index 68e75e9c..256ae40d 100755 --- a/release.sh +++ b/release.sh @@ -658,13 +658,18 @@ function publish_artifacts() { # Sets the github release with the highest semver to 'latest' function set_latest_to_highest_semver() { - local last_version # don't combine with the line below, or $? will be 0 + if ! (( PUBLISH_TO_GITHUB )); then + return 0 + fi + echo "Setting latest release to highest semver" + + local last_version release_id # don't combine with assignment else $? will be 0 + last_version="$(hub_tool -p release | cut -d'-' -f2 | grep '^v[0-9]\+\.[0-9]\+\.[0-9]\+$'| sort -r -V | head -1)" if ! [[ $? -eq 0 ]]; then abort "cannot list releases" fi - local release_id # don't combine with the line below, or $? will be 0 release_id="$(hub_tool api "/repos/${ORG_NAME}/${REPO_NAME}/releases/tags/knative-${last_version}" | jq .id)" if [[ $? -ne 0 ]]; then abort "cannot get relase id from github" @@ -701,6 +706,8 @@ function main() { function_exists build_release || abort "function 'build_release()' not defined" [[ -x ${VALIDATION_TESTS} ]] || abort "test script '${VALIDATION_TESTS}' doesn't exist" + banner "Environment variables" + env # Log what will be done and where. banner "Release configuration" if which gcloud &>/dev/null ; then