Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make pingsource adapter controller read-only #4099

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

lionelvillard
Copy link
Member

Fixes #4028

Proposed Changes

  • The adapter controller does not attempt to update the CR status
  • Revert to previous behavior when the source is not ready. When a pod is deleted, a source becomes temporarily not ready, leading to lost events.

Release Note


Docs

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 22, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 22, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2020
@lionelvillard
Copy link
Member Author

/cc @cr22rc

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/mtping/controller.go 87.5% 88.9% 1.4
pkg/adapter/mtping/pingsource.go 71.4% 83.3% 11.9

Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Leaving lgtm to @cr22rc

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests:

test/conformance.TestBrokerV1Beta1DataPlaneConsumer/MTChannelBasedBroker-eventing.knative.dev/v1beta1/Events_are_filtered
test/conformance.TestBrokerV1Beta1DataPlaneConsumer/MTChannelBasedBroker-eventing.knative.dev/v1beta1
test/conformance.TestBrokerV1Beta1DataPlaneConsumer
.Test

@lionelvillard
Copy link
Member Author

/test pull-knative-eventing-conformance-tests

@cr22rc
Copy link
Contributor

cr22rc commented Sep 23, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@knative-prow-robot knative-prow-robot merged commit 5741e8f into knative:master Sep 23, 2020
@aliok aliok mentioned this pull request Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pingsource-controller cannot update pingsources/status
7 participants