Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ApiServerSource v1beta1 the stored version and add a migration tool #4031

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Make ApiServerSource v1beta1 the stored version and add a migration tool #4031

merged 1 commit into from
Sep 11, 2020

Conversation

capri-xiyue
Copy link
Contributor

Fixes #3630

Proposed Changes

  • Add a Preinstall job that migrates apiserversources from v1alpha1 to v1beta1.

Release Note

action required: You must run pre-install job prior to upgrading to get apiserversource to v1beta1 API.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 10, 2020
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 10, 2020
@capri-xiyue
Copy link
Contributor Author

/assign @lionelvillard

@n3wscott
Copy link
Contributor

/lgtm
/approve

Thanks!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020
@capri-xiyue
Copy link
Contributor Author

/test pull-knative-eventing-unit-tests

@knative-prow-robot knative-prow-robot merged commit a44dbdb into knative:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok Awaiting requested review from aliok

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@lionelvillard lionelvillard

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ApiServerSource v1beta1 the stored version and add a migration tool
5 participants
@capri-xiyue @n3wscott @knative-prow-robot @googlebot @lionelvillard