Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtping adapter controller can now be easily generated. #4008

Merged
merged 3 commits into from
Sep 15, 2020
Merged

mtping adapter controller can now be easily generated. #4008

merged 3 commits into from
Sep 15, 2020

Conversation

lionelvillard
Copy link
Member

Proposed Changes

  • 🧽 Move adapter state processing out of the controller/reconciler files

Release Note

Docs

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 4, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 4, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2020
@lionelvillard lionelvillard mentioned this pull request Sep 4, 2020
Merged
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 2020-09-05 22:53:54.602 +0000 UTC
2020-09-05 23:08:25.345 +0000 UTC		 2/3
pull-knative-eventing-integration-tests 2020-09-05 22:54:27.6 +0000 UTC
2020-09-05 23:08:55.272 +0000 UTC
2020-09-05 23:22:55.472 +0000 UTC		 3/3

Automatically retrying due to test flakiness...
/test pull-knative-eventing-integration-tests

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 2020-09-05 22:53:54.602 +0000 UTC
2020-09-05 23:08:25.345 +0000 UTC
2020-09-05 23:22:55.472 +0000 UTC		 3/3
pull-knative-eventing-integration-tests 2020-09-05 22:54:27.6 +0000 UTC
2020-09-05 23:08:55.272 +0000 UTC		 2/3

Automatically retrying due to test flakiness...
/test pull-knative-eventing-conformance-tests

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 14, 2020
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 14, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/mtping/adapter.go 63.2% 79.5% 16.3
pkg/adapter/mtping/controller.go 100.0% 87.5% -12.5
pkg/adapter/mtping/pingsource.go 75.0% 71.4% -3.6
pkg/adapter/v2/main.go 58.9% 61.1% 2.1

@lionelvillard
Copy link
Member Author

/test pull-knative-eventing-unit-tests

@lionelvillard lionelvillard changed the title WIP: mtping adapter controller can now be easily generated. mtping adapter controller can now be easily generated. Sep 14, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2020
@cr22rc
Copy link
Contributor

cr22rc commented Sep 15, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2020
@knative-prow-robot knative-prow-robot merged commit b170c67 into knative:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantr grantr Awaiting requested review from grantr

@nlopezgi nlopezgi Awaiting requested review from nlopezgi

Assignees

@cr22rc cr22rc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lionelvillard @knative-prow-robot @knative-test-reporter-robot @knative-metrics-robot @cr22rc @googlebot