Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition #3960 #3992

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Fix race condition #3960 #3992

merged 1 commit into from
Sep 3, 2020

Conversation

slinkydeveloper
Copy link
Contributor

Signed-off-by: Francesco Guardiani [email protected]

Fixes #3960

@slinkydeveloper
Fix race condition knative#3960
0b5df56 
Signed-off-by: Francesco Guardiani <[email protected]>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 2, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 2, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@matzew
Copy link
Member

matzew commented Sep 3, 2020

/test all

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/inmemorychannel/dispatcher/controller.go 83.3% 80.0% -3.3

aliok
aliok approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Clever and simple fix!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 0/3
pull-knative-eventing-integration-tests 0/3
pull-knative-eventing-upgrade-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

.Test

@slinkydeveloper
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot merged commit bc5e2fa into knative:master Sep 3, 2020
@aliok aliok mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok aliok approved these changes

@aslom aslom Awaiting requested review from aslom

@yolocs yolocs Awaiting requested review from yolocs

Assignees

@aliok aliok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data race in IMC dispatcher
7 participants
@slinkydeveloper @matzew @knative-metrics-robot @knative-prow-robot @knative-test-reporter-robot @aliok @googlebot