Refactor broker data plane consumer tests conf tests #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the tests to have the test resources setup first, and then just use them in the following tests. Hopefully this increases the stability of the broker tests Related: knative#3791
knative-prow-robot
added
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lberk, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
vaikas
reviewed
Aug 27, 2020
| "reply-check-source", | ||
| transformMsg, | ||
| ) | ||
| client.CreatePodOrFail(transformPod, testlib.WithService(transformerName)) |
There was a problem hiding this comment.
I wonder if we should've waited here for endpoints ready instead of in the test, but I see you do it in the test, let's see if that helps. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the tests to have the test resources setup first, and then
just use them in the following tests. Hopefully this increases the
stability of the broker tests
Related: #3791