-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First attempt to explain how config works in receive adapters #3896
First attempt to explain how config works in receive adapters #3896
Conversation
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests:
|
This fails due to:
How reliable is
|
/test pull-knative-eventing-conformance-tests |
port forwarding reliability is something that @slinkydeveloper was looking at |
/test pull-knative-eventing-conformance-tests |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
Thanks for this doc work. I only have a small comment.
Feel free to unhold.
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, lionelvillard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes
Release Note
Docs