Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add anti-affinity to our control plane deployments #3795

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Add anti-affinity to our control plane deployments #3795

merged 1 commit into from
Aug 6, 2020

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Aug 6, 2020

Related: knative/pkg#1269

  • 🧽 Update or clean up current behavior
Control plane components now specify anti-affinity so that replicas will not be colocated.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 6, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 6, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Aug 6, 2020

/retest

Not sure why this change would cause that sort of failure (which I have never seen before).

n3wscott
n3wscott reviewed Aug 6, 2020
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor
Copy link
Member Author

mattmoor commented Aug 6, 2020

/retest

@pierDipi
Copy link
Member

pierDipi commented Aug 6, 2020

#3570

Failed to start the EventInfoStore associated to pod 'e2e-sink-binding-recordevent-pod': timeout waiting for recordevents pod to come up: http get error: Get "http://localhost:46032/minmax": dial tcp 127.0.0.1:46032: connect: connection refused

/retest

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 0/3
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestSinkBindingCronJob

@mattmoor
Copy link
Member Author

mattmoor commented Aug 6, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit e4bc346 into knative:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott left review comments

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@nachocano nachocano Awaiting requested review from nachocano

Assignees

@grantr grantr

@lionelvillard lionelvillard

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mattmoor @knative-prow-robot @pierDipi @knative-test-reporter-robot @n3wscott @grantr @googlebot @lionelvillard