Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate parallel reconciler to use messaging.* v1 resources #3788

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

nlopezgi
Copy link
Contributor

@nlopezgi nlopezgi commented Aug 5, 2020

Part of #3584

Proposed Changes

  • Migrate parallel reconciler to use messaging.* v1 resources

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 5, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 5, 2020
@matzew
Copy link
Member

matzew commented Aug 6, 2020

test/conformance.TestBrokerV1Beta1ControlPlane/InMemoryChannel-messaging.knative.dev/v1/Ready_Trigger_V1Beta1_(no_Broker)_set_Broker_and_includes_status.subscriber_Uri
test/conformance.TestBrokerV1Beta1ControlPlane/InMemoryChannel-messaging.knative.dev/v1
test/conformance.TestBrokerV1Beta1ControlPlane

let's do a

/retest

Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold

Holding for others' review

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2020
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2020
@nlopezgi
Copy link
Contributor Author

nlopezgi commented Aug 6, 2020

@aliok , @matzew thanks for the review. Tests are now passing and this is ready.

@aliok
Copy link
Member

aliok commented Aug 6, 2020

/unhold

Checked with Matthias.

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2020
@matzew
Copy link
Member

matzew commented Aug 6, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2020
@nlopezgi
Copy link
Contributor Author

nlopezgi commented Aug 6, 2020

/test pull-knative-eventing-conformance-tests

@nlopezgi
Copy link
Contributor Author

nlopezgi commented Aug 6, 2020

/test pull-knative-eventing-unit-tests

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 0/3
pull-knative-eventing-integration-tests 2020-08-06 15:58:50.099 +0000 UTC 1/3

Automatically retrying due to test flakiness...
/test pull-knative-eventing-integration-tests

@knative-prow-robot knative-prow-robot merged commit acf9c29 into knative:master Aug 6, 2020
@aliok aliok mentioned this pull request Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants