Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added v1beta1 apiserversource type #3614

Merged
merged 4 commits into from
Jul 17, 2020
Merged

added v1beta1 apiserversource type #3614

merged 4 commits into from
Jul 17, 2020

Conversation

capri-xiyue
Copy link
Contributor

@capri-xiyue capri-xiyue commented Jul 16, 2020 •
edited
Loading

Helps with #3611

Proposed Changes

  • 🎁 Adding ApiServerSource v1beta1 types.
  • Fixed bug in apiserver_lifecycle for v1alpha1 and v1alpha2

Release Note

None

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 16, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 16, 2020
@capri-xiyue
Copy link
Contributor Author

/assign @nachocano @lionelvillard

@capri-xiyue capri-xiyue mentioned this pull request Jul 16, 2020
Merged
@capri-xiyue
Copy link
Contributor Author

/test pull-knative-eventing-integration-tests

nachocano
nachocano reviewed Jul 16, 2020
View reviewed changes
pkg/apis/sources/v1alpha1/apiserver_lifecycle.go
@@ -126,7 +126,7 @@ func (s *ApiServerSourceStatus) PropagateDeploymentAvailability(d *appsv1.Deploy
}
}
if !deploymentAvailableFound {
PingSourceCondSet.Manage(s).MarkUnknown(PingSourceConditionDeployed, "DeploymentUnavailable", "The Deployment '%s' is unavailable.", d.Name)
apiserverCondSet.Manage(s).MarkUnknown(ApiServerConditionDeployed, "DeploymentUnavailable", "The Deployment '%s' is unavailable.", d.Name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

nachocano
nachocano reviewed Jul 16, 2020
View reviewed changes
pkg/apis/sources/v1beta1/apiserver_defaults_test.go Outdated
)

// No-op test because method does nothing.
func TestAPIServerSourceDefaults(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add logic here now, as we are doing some defaulting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@nachocano
Copy link
Contributor

Thanks @capri-xiyue !!!
Just a few nits that I think can be removed and we get this one in.

@nachocano
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/sources/v1alpha2/apiserver_lifecycle.go 92.9% 96.2% 3.3
pkg/apis/sources/v1beta1/apiserver_conversion.go Do not exist 100.0%
pkg/apis/sources/v1beta1/apiserver_defaults.go Do not exist 100.0%
pkg/apis/sources/v1beta1/apiserver_lifecycle.go Do not exist 96.2%
pkg/apis/sources/v1beta1/apiserver_types.go Do not exist 100.0%
pkg/apis/sources/v1beta1/apiserver_validation.go Do not exist 90.0%

@capri-xiyue
Copy link
Contributor Author

/test pull-knative-eventing-integration-tests

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/conformance.TestChannelDataPlaneSuccess
test/conformance.TestChannelDataPlaneSuccess/InMemoryChannel-messaging.knative.dev/v1
test/conformance.TestChannelDataPlaneSuccess/InMemoryChannel-messaging.knative.dev/v1/full-event_encoding_structured_version_0.3

@capri-xiyue
Copy link
Contributor Author

/test pull-knative-eventing-integration-tests

@knative-prow-robot knative-prow-robot merged commit 4b0317d into knative:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nachocano nachocano nachocano left review comments

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

Assignees

@nachocano nachocano

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@capri-xiyue @nachocano @knative-prow-robot @knative-metrics-robot @knative-test-reporter-robot @googlebot @lionelvillard