Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Without this RBAC, leaderelection cannot be enabled. #3562

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Without this RBAC, leaderelection cannot be enabled. #3562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions config/core/roles/controller-clusterroles.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,3 +133,10 @@ rules:
- "get"
- "list"
- "watch"

# For leader election
- apiGroups:
- "coordination.k8s.io"
resources:
- "leases"
verbs: *everything
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, watch and list are not needed.

7 changes: 7 additions & 0 deletions config/core/roles/webhook-clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,13 @@ rules:
- "sinkbindings/finalizers"
verbs: *everything

# For leader election
- apiGroups:
- "coordination.k8s.io"
resources:
- "leases"
verbs: *everything

# Necessary for conversion webhook. These are copied from the serving
# TODO: Do we really need all these permissions?
- apiGroups: ["apiextensions.k8s.io"]
Expand Down