Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Without this RBAC, leaderelection cannot be enabled. #3562

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Without this RBAC, leaderelection cannot be enabled. #3562

merged 1 commit into from
Jul 10, 2020

Conversation

mattmoor
Copy link
Member

  • 🐛 Fix bug
Add missing "leases" RBAC to controller and webhook to support leader election.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 10, 2020
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 10, 2020
@vaikas
Copy link
Contributor

vaikas commented Jul 10, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor
Copy link
Member Author

FYI, I uncovered this while testing with LE enabled everywhere here: #3561

lionelvillard
lionelvillard reviewed Jul 10, 2020
View reviewed changes
config/core/roles/controller-clusterroles.yaml
- "coordination.k8s.io"
resources:
- "leases"
verbs: *everything
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, watch and list are not needed.

@knative-prow-robot knative-prow-robot merged commit bd76931 into knative:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionelvillard lionelvillard lionelvillard left review comments

@grantr grantr Awaiting requested review from grantr

Assignees

@mgencur mgencur

@pmorie pmorie

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mattmoor @vaikas @knative-prow-robot @lionelvillard @mgencur @pmorie @googlebot