Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding istio annotation #3534

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Adding istio annotation #3534

merged 1 commit into from
Jul 9, 2020

Conversation

vayyappaneni
Copy link
Contributor

Fixes #3532

Proposed Changes

  • Fixing issue where jobs do not complete on istio enabled cluster

Release Note

Fixes issue where migration jobs would fail on Istio cluster with auto-inject enabled

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2020
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 7, 2020
@knative-prow-robot
Copy link
Contributor

Welcome @vayyappaneni! It looks like this is your first PR to knative/eventing 🎉

@knative-prow-robot
Copy link
Contributor

Hi @vayyappaneni. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AceHack
Copy link
Contributor

AceHack commented Jul 7, 2020

I'm having this issue too

@AceHack
Copy link
Contributor

AceHack commented Jul 7, 2020

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2020
@vayyappaneni
Copy link
Contributor Author

/assign @tcnghia

@vayyappaneni
Copy link
Contributor Author

/retest

@tcnghia
Copy link

tcnghia commented Jul 8, 2020

/test pull-knative-eventing-upgrade-tests

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-upgrade-tests pull-knative-eventing-upgrade-tests
pull-knative-eventing-upgrade-tests
pull-knative-eventing-upgrade-tests
pull-knative-eventing-upgrade-tests		 3/3

Job pull-knative-eventing-upgrade-tests expended all 3 retries without success.

@AceHack
Copy link
Contributor

AceHack commented Jul 9, 2020

/test pull-knative-eventing-upgrade-tests

@AceHack
Copy link
Contributor

AceHack commented Jul 9, 2020

@tcnghia I've seen this test pull-knative-eventing-upgrade-tests fail on several other PRs that seem random, do you think this is a random failure?

@AceHack
Copy link
Contributor

AceHack commented Jul 9, 2020

@tcnghia seems like it was, do you know how to trigger the cla/google check? I know @vayyappaneni has signed it so I'm not sure how to trigger it. Thanks.

@pierDipi
Copy link
Member

pierDipi commented Jul 9, 2020

The author needs to comment with: @googlebot I signed it!

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 9, 2020
@vayyappaneni
Copy link
Contributor Author

@googlebot I signed it!

@pierDipi
Copy link
Member

pierDipi commented Jul 9, 2020

@vayyappaneni, would you mind rebasing?

@vayyappaneni
Copy link
Contributor Author

@pierDipi working on it...

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2020
@vaikas
Copy link
Contributor

vaikas commented Jul 9, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas, vayyappaneni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2020
@knative-prow-robot knative-prow-robot merged commit 88a6f84 into knative:master Jul 9, 2020
@vayyappaneni vayyappaneni deleted the istiofix branch July 9, 2020 16:40
This was referenced Jul 9, 2020
Merged
Merged
knative-prow-robot pushed a commit that referenced this pull request Jul 12, 2020
@vayyappaneni @mattmoor
adding istion annotation (#3534) (#3557)
acdd118 
* adding istion annotation (#3534)

* backporting #3543

* Update test/lib/duck/resource_inspectors.go

Co-authored-by: Matt Moore <[email protected]>

* Use the standard resource creation libs for upgrade tests. (#3539)

* try to dump some state

* use client wait or fail

* create broker directly

* removed the unused import

Co-authored-by: Matt Moore <[email protected]>
matzew pushed a commit to matzew/eventing that referenced this pull request Sep 30, 2020
@vayyappaneni @mattmoor @matzew
adding istion annotation (knative#3534) (knative#3557)
555f645 
* adding istion annotation (knative#3534)

* backporting knative#3543

* Update test/lib/duck/resource_inspectors.go

Co-authored-by: Matt Moore <[email protected]>

* Use the standard resource creation libs for upgrade tests. (knative#3539)

* try to dump some state

* use client wait or fail

* create broker directly

* removed the unused import

Co-authored-by: Matt Moore <[email protected]>
matzew pushed a commit to matzew/eventing that referenced this pull request Oct 1, 2020
@vayyappaneni @mattmoor @matzew
adding istion annotation (knative#3534) (knative#3557)
6c2808e 
* adding istion annotation (knative#3534)

* backporting knative#3543

* Update test/lib/duck/resource_inspectors.go

Co-authored-by: Matt Moore <[email protected]>

* Use the standard resource creation libs for upgrade tests. (knative#3539)

* try to dump some state

* use client wait or fail

* create broker directly

* removed the unused import

Co-authored-by: Matt Moore <[email protected]>
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Oct 7, 2020
@matzew @vayyappaneni
@mattmoor @vaikas
Add backports form 0.16.x releases (#864)
35d2c08 
* adding istion annotation (knative#3534) (knative#3557)

* adding istion annotation (knative#3534)

* backporting knative#3543

* Update test/lib/duck/resource_inspectors.go

Co-authored-by: Matt Moore <[email protected]>

* Use the standard resource creation libs for upgrade tests. (knative#3539)

* try to dump some state

* use client wait or fail

* create broker directly

* removed the unused import

Co-authored-by: Matt Moore <[email protected]>

* cp 3897 (knative#3902)

* cp 3897

* backport 3719

* x bit

* apiserversource v1beta1->v1alpha2

* install broker / sugar

* backport 3945 to .16 (knative#3948)

Co-authored-by: VijayaSenaReddy Ayyappaneni <[email protected]>
Co-authored-by: Matt Moore <[email protected]>
Co-authored-by: Ville Aikas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok Awaiting requested review from aliok

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@tcnghia tcnghia

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage-version-migration job never completes on istio enabled cluster
8 participants
@vayyappaneni @knative-prow-robot @AceHack @tcnghia @knative-test-reporter-robot @pierDipi @vaikas @googlebot