Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow v1 crd #3418

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Flow v1 crd #3418

merged 2 commits into from
Jun 30, 2020

Conversation

lionelvillard
Copy link
Member

Fixes #3335

Proposed Changes

  • Serve flow v1 API

Release Note

Docs

/hold

Waiting for the conversion webhook to be in.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 25, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 25, 2020
mattmoor
mattmoor reviewed Jun 25, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/duck/v1beta1/delivery_conversion.go 68.8% 70.6% 1.8

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 26, 2020
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2020
@lionelvillard
Copy link
Member Author

/test pull-knative-eventing-upgrade-tests

@aliok aliok mentioned this pull request Jun 29, 2020
Closed
@lionelvillard
Copy link
Member Author

/test pull-knative-eventing-upgrade-tests

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2020
@lionelvillard
Copy link
Member Author

/test pull-knative-eventing-upgrade-tests

@vaikas
Copy link
Contributor

vaikas commented Jun 29, 2020

@lionelvillard I'm running into similar ordering issues with upgrade tests in #3430

for: "STDIN": CustomResourceDefinition.apiextensions.k8s.io "parallels.flows.knative.dev" is invalid: spec.version: Invalid value: "v1alpha1": must match the first version in spec.versions

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 29, 2020
@matzew
Copy link
Member

matzew commented Jun 29, 2020

@lionelvillard I'm running into similar ordering issues with upgrade tests in #3430

same here w/ my #3360 - lame, but yeah ...

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-upgrade-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-upgrade-tests:

test/upgrade.TestContinuousEventsPropagationWithProber

@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 29, 2020
@lionelvillard
Copy link
Member Author

@vaikas that did it!

matzew
matzew reviewed Jun 29, 2020
View reviewed changes
cmd/webhook/main.go Outdated
@@ -297,8 +287,6 @@ func NewConversionController(ctx context.Context, cmw configmap.Watcher) *contro
},
},

=======
>>>>>>> v1 <-> v1beta1 flow conversion webhook
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

matzew
matzew approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lionelvillard,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 04533ee into knative:master Jun 30, 2020
@lionelvillard lionelvillard mentioned this pull request Jun 30, 2020
Closed
8 tasks
@lionelvillard lionelvillard deleted the flow-v1-crd branch September 3, 2020 15:33
@lionelvillard lionelvillard restored the flow-v1-crd branch September 3, 2020 15:42
@lionelvillard lionelvillard deleted the flow-v1-crd branch September 3, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@matzew matzew matzew approved these changes

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement v1 API for flows.* resources
8 participants
@lionelvillard @knative-metrics-robot @vaikas @matzew @knative-test-reporter-robot @knative-prow-robot @mattmoor @googlebot