Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook Certs Should be Created Before Webhook #4163

Closed
ian-mi opened this issue Sep 29, 2020 · 1 comment
Closed

Webhook Certs Should be Created Before Webhook #4163

ian-mi opened this issue Sep 29, 2020 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ian-mi
Copy link
Contributor

ian-mi commented Sep 29, 2020

Describe the bug
If the eventing-webhook deployment is created before the the eventing-webhook-certs secret, the pod will crash with an error such as

secret "eventing-webhook-certs" is missing "ca-cert.pem"

Expected behavior
The eventing-webhook-certs secret should be ordered so that it is always created before the eventing-webhook deployment.

To Reproduce
Apply the eventing release yaml sufficiently many times to reproduce this error.

Knative release version
v0.17.2

@ian-mi ian-mi added the kind/bug Categorizes issue or PR as related to a bug. label Sep 29, 2020
@ian-mi
Copy link
Contributor Author

ian-mi commented Sep 29, 2020

This doesn't appear to be the root cause, see #4165.

@ian-mi ian-mi closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant